Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
deps: upgrade to gopls and x/tools 5e752206 (#584)
Includes changes to govim to: * handle type changes in code generated LSP API types * define "CompletionBudget" config value for use in integration tests * remove skip from scenario_default/format_on_save_new_file script * add scenario_default/format_on_save_new_file_existing_package to verify the addition of a new file to an existing package * make changes to various scripts to handle the fact that gopls now only sends diagnostics for a file when they have changed gopls and x/tools changes: * internal/lsp: don't clear file contents on save 5e752206 * internal/lsp/cache: detach context before invalidation 145a1e40 * internal/lsp/cache: remove errors from dependencies 041a08a5 * internal/lsp/cache: consolidate function to update overlays 85a33566 * internal/imports: consider direct mod deps more relevant 62b96743 * internal/lsp: eliminate source.File type and move GetFile to snapshot 2208e167 * internal/lsp: put verbose go/packages output behind verboseOutput flag 56b0b28a * internal/lsp: fix highlighting of inexact matches when highlighting from the right bdebc07e * internal/lps/protocol: bring code.ts up to date with latest changes. a98e7fcf * telemetry/log: sample reference for benchmarking harness 2ad5dca7 * internal/lsp: add gopls setting to disable use of -modfile flag behavior 3aa5a364 * go/packages: change import cycle errorkind from UnknownError to ListError 4f29fbcc * internal/lsp/cache: fix excessive recursion in (*snapshot).clone() 979b82bf * internal/lsp/cache: don't forget files just because they change 84f0c7cf * all: burn all the evidence ac281547 * internal/lsp: return snapshots from text modifications ca0407e6 * internal/lsp/source: fix completion budget type 41c101f3 * internal/lsp: show comments for grouped variable declarations 61483d10 * blog: fix swallowed error 61f5e7d2 * internal/lsp/cache: move overlay and debug handling into separate files d270ebf9 * internal/lsp/cache: don't invalidate dependents' metadata bc4a8d39 * internal/lsp/debug: print the debug port 6f9e13bb * internal/lsp: use the -modfile flag to update a different go.mod file 62a96288 * cmd/fiximports: fix 'go list' error formatting 210e553f * internal/lsp: fix links for interface methods 38570b76 * internal/lsp: kill some dead code 64005949 * internal/lsp: change completionBudget to milliseconds f2a421a9 * internal/imports: set the Dir field on the build.Context (instead of WorkingDir) if present 01c78d57 * fix: using section links to IDE specific doc 0b436227 * gopls: add status and roadmap to the main readme. bbbf87ae * internal/lsp: fix link anchors for struct fields 42268a1f * internal/lsp: expose option to disable timeouts for completion c39ce214 * imports: pass more of the environment 621d4eef * internal/lsp/source: fix crash on conflict markers in imports 846828e8 * internal/lsp: change CompletionItem.{Command,TextEdit} to pointers 1d943b09 * internal/lsp/cache: consolidate snapshot cloning 4981f6b3 * internal/gopathwalk/walk: add missing function descriptions and renaming 99b39703 * benchmark/parse: add unit test for String function bcb65d52 * internal/lsp: fix find-implementation for promoted methods a6aac22f * go/analysis: gofmt snippets in package documentation 53d48bfc * internal/lsp, internal/tool: clean up command line of gopls a0e659d5 * internal/lsp: remove useless signature cast completion candidate 49a3e744 * internal/lsp: skip return highlighting if cursor is in arglist of func 04c2e8ef * internal/lsp: create parseModHandle for storing go.mod data 56463cc1 * internal/lsp: add diagnostic on import causing import cycle 7ebc6af0 * internal/lsp/source: fix error message for multiple GOPATHs 74e303f8 * internal/lsp/tests: add error handling for @item() 27b81bef * go/packages: correct logging of driver stderr 7093a17b * internal/lsp: offer basic type conversion candidates 0f69de23 * internal/lsp: improve link in documentation on hover cfcbc779 * go/packages: disable -mod=readonly behavior in overlays 8facea2e * internal/lsp: downrank "nil" completion candidate 825cb062 * internal/lsp: don't resend diagnostics if they are unchanged 56eb7d2c * internal/lsp: move DidModifyFile into internal/lsp/cache 4403f798 * internal/lsp: fix find-references to search from all package variants dfebd280 * internal/lsp: add handling for go.mod files in internal/lsp functions ad473c03 * internal/lsp: invalidate metadata and type info more selectively 4da4485a * internal/lsp/source: fix all types in resolveInvalid ec14b296 * internal/lsp: invalidate workspace packages when go.mod file changes ac2db28e * internal/lsp: check all package variants in find-implementations a27fdba2 * internal/lsp: fix circular import errors to account for import stack 37853707 * go/packages: add import stack to error messages when there's an import cycle 0d087302 * internal/lsp: don't invalidate dependents' metadata 912f50ad * internal/lsp: add comment completions for exported vars 98df1237 * internal/lsp: suggest "fallthrough" only inside switches fe93f4a7 * internal/lsp: Make Text in DidSave at *string rather than a string 1bcf67c9 * internal/lsp: make Text in DidSave request a pointer 0bd90eac * internal/lsp/cache: invalidate metadata even without Create 22774f7d * internal/lsp: fix control flow highlighting taking precedence 115af5e8 * internal/lsp: trim down implementations code 9a30a9a9 * internal/lsp: tweak implementation tests 259af5ff * internal/lsp: fix error suppression in (*session).createView bc369361 * internal/lsp/source: optimize computeFixEdits 6d582d50 * internal/lsp/source: cap number of unimported completions 330b9f13 * internal/lsp: respect References.IncludeDeclaration setting 786dcba0 * internal/lsp: add error handling for self imports cec95805 * internal/lsp: fix concurrent map write in file invalidation db903f39 * internal/lsp: propagate and handle context cancellation errors 3393d29b * internal/lsp/cache: clean up dead code after CL 209737 7b8c8591 * internal/lsp: fix golden generation for import tests addffd16 * internal/lsp: expose godoc or pkg.go.dev link on hover 69111344 * internal/memoize: fix race on read of handle.function 61fa4dff * go/packages: remove obsolete comment about LoadMode in doc.go e140590b * internal/lsp: refactor and clean up text synchronization d1f10d1c * internal/lsp: return snapshot when creating a view a5887330 * internal/lsp: fix AST bookkeeping as we repair nodes 73c7173a * internal/lsp/cmd: use x/tools/gopls as the gopls bug prefix e84277c2 * internal/lsp: propagate errors through source.DocumentSymbols 7a2a8a04 * internal/lsp: run packages.Load only if imports are added or changed ac417207 * go/packages: revert "handle invalid files in overlays" 427c522c * internal/lsp: always ParseFull in-workspace dependencies d79e56da * go/analysis/internal/checker: format files modified by -fix 0d967eff * internal/lsp/source: extract helper, improve error messages 660eba4d * internal/lsp/cache: fix load race, refactor 9611592c * gopls/integration: remove commented-out debug code b1451cf3 * gopls/integration: add the replay command to replay LSP logs c197fd4b * internal/links: improve links parser, no protocol specification db047d72 * playground/socket: handle multi-file present play snippets 8db96347 * internal/lsp: improve completion after accidental keywords 5ae4576c * internal/lsp: add nil check for control flow highlighting 2b6af5f9 * internal/imports: make ApplyFixes work despite syntax errors 5a103c92 * internal/lsp: add control flow highlighting for functions aa29eadb * internal/lsp/protocol: replace code for generating LSP types and stubs 713d4893 * internal/lsp: suppress all errors when a view is loaded and checked ffc413ea * internal/lsp: rename CheckPackageHandle to PackageHandle a51b8faf * internal/lsp: link to the new pkg.go.dev instead of godoc.org 6e064ea0 * internal/lsp: make sure CodeAction.Command is a pointer ecd32218 * lsp/protocol: make sure RenameProvider is an interface{} c1736c0f * internal/telemetry: lift the tests up to the request level 99399511 * gopls/doc: add documentation for gopls with Atom 724660f1 * internal/telemtry: changed to a simpler threading model for stats 7360bd5c * internal/lsp: build the wire.Node lazily 9fe613bd * internal/lsp: add some minimal validation for client capabilities 69a79c76 * internal/lsp: fixes premature return in find implementations e13f15d1 * internal/lsp: remove duplicate implementations when finding implementations af857703 * tools/gopls: add cmd support for highlight 20805546 * cmd/gopls/integration: remove old VS Code extension for debugging b832835c * internal/telemetry: delay the conversion of metrics fc82735a * godoc/static: re-add "or" function call to package.html template b0650ceb * internal/lsp: don't run analyses on the entire view 73cd2cc3 * internal/lsp/source: fix crash on short file 9f1eb440 * internal/lsp/tests: skip cgo tests when not supported efa86633 * internal/lsp: do not return interface itself when finding implementations 73db347c * internal/lsp/source: give more imports names 66af5afb * tools/gopls: add cmd support for implementation 59b2cd78 * internal/lsp: fix return variables for FindPosInPackage b99b2d09 * internal/lsp: set version correctly after textDocument/didOpen d7101b74 * internal/lsp: add tests for cgo package users 05c67e95 * internal/lsp: track and parse non-compiled go files ef6787d3 * internal/span: support line directives 761dbfd6 * internal/lsp: add documentation for package-level vars acc15743 * internal/lsp: fix literal completions in variadic params a99e43fc * internal/lsp: only search for references in reverse dependencies a911d900 * internal/telemetry: make the metrics tests external 89d49d94 * internal/lsp: use AST to construct placeholders cc15fab3 * internal/telemetry: merge the metrics tests f5828fc9 * internal/telemetry: compare the compact JSON 2a6ccf25 * internal/lsp: handle first change behavior on the server side c02aa52d * internal/lsp/cache: disable analysis on dependencies (temporarily) 2189885d * internal/lsp: improve completion ordering workaround 035a8167 * internal/lsp: fix a race in the command line tests 0ae87fff * internal/telemetry/export/ocagent: update usages of BucketOptions to use pointers f774e2e2 * internal/telemetry/export/ocagent: add tutorial for exporting metrics df8e87c2 * internal/telemetry/export/ocagent: correctly JSON marshal BucketOptionsExplicit 2d3bb8ce * internal/lsp: use snapshot to get reverse dependencies f191eec9 * internal/lsp: delete the source.Diagnostic.File field 004141db * cmd/godoc: delete unused autocert hooks f51c1a7c * internal/lsp: add control flow highlighting inside for loops 66c5a5ad * cmd/godoc: don't execute go list -m all when GOMOD is /dev/null 91381dc0 * internal/lsp: use version numbers in diagnostic messages eaeb3832 * internal/lsp: don't clear diagnostics on file close cb050682 * internal/telemetry/export/ocagent: correctly marshal points to JSON 96ad48e4 * internal/lsp: fix diagnostics on didChange 82924fac * internal/lsp: make the ocagent test external 947d4aa8 * internal/telemetry: delay the conversion to wire format 9c44060b * internal/lsp: reorganize and refactor code 35ba81b9 * internal/lsp: rename Files to CompiledGoFiles 8fd45951 * internal: avoid use of (*token.File).Name 328c41bf * internal/lsp: fix and re-enable godef tests 4bf2f406 * txtar/archive: add unit test function for Format 17847a84 * cmd/godoc, godoc/static: remove remnants of golang.org website 688c506a * internal/lsp: make Range a pointer in Change events cefbc64f * internal/lsp: improve highlighting functionality for fields and methods 0a33398b * cmd/digraph: omit unnecessary empty lines in focus b3340bdf * cmd/digraph: add focus e97fc272 * internal/lsp: run diagnostics on the entire workspace ad01d599 * internal/lsp: handle breakage caused by CL 207598 7f7817c0 * txtar: promote from internal 298f0cb1 * internal/lsp: only construct a cache when we need to caaa49c6 * go/analysis/passes/lostcancel: fix typo 4054736f * all: fix typo ("identifer" → "identifier") dc59f20e * internal/lsp/cmd: don't create .orig files for rename by default 6d480e29 * internal/lsp: fix the return type of CodeAction() 11e13f1c * internal/lsp: fix infinite recursion in CancelRequest 07fc4c7f * go/packages: add String methods for LoadMode 3d1ebf6f * internal/lsp/protocol: fix type of WorkspaceEdit.Changes in tsprotocol.go 13f8be5f * go/analysis/passes: ensure diagnostic-reporting analyses have exported Doc 1ef994f2 * internal/lsp: don't search other packages for unexported references faf0e61b * internal/lsp: reorganize the generated Go code for the lsp protocol 5091d647 * internal/lsp: fix variadic interface completion ranking 5a76f03b * internal/lsp: fix panic in bestView 80313e1b * internal/lsp: fix panic when logging errors in snapshot.KnownPackages 3a792d9c * cmd/godoc: don't execute go mod download when GOMOD is /dev/null 1c71899d * internal/lsp/testadata/rename: add a test case for renames across packages 4191b8cb * internal/lsp: ignore AST errors when generating import edits 634482ed * internal/lsp/source: add support for references in the same workspace caa0b0f7 * internal/lsp: use import path literal for documentLink range a764947c * internal/lsp/cache: add finer-grained control of file changes faa69481 * cmd/benchcmp: add unit test for formatNs function bd32a3e7 * internal/lsp: use the versions provided by the client e2727e81
- Loading branch information