Skip to content

Commit

Permalink
cmd/govim: re-enable incremental updates by default (#267)
Browse files Browse the repository at this point in the history
Noting however #266 which is a
known issue. Re-enabling on the basis it's probably better to get more
exposure for this feature in the short term, particularly when there is
a workaround for people who use auto-pairs.
  • Loading branch information
myitcv committed Jun 3, 2019
1 parent 0af2302 commit 4c35102
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cmd/govim/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,8 @@ func (g *govimplugin) doIncrementalSync() bool {
if semver.Compare(g.Version(), testsetup.MinVimIncrementalSync) < 0 {
return false
}
if os.Getenv(testsetup.EnvDisableIncrementalSync) == "false" {
return true
if os.Getenv(testsetup.EnvDisableIncrementalSync) == "true" {
return false
}
return false
return true
}
1 change: 1 addition & 0 deletions cmd/govim/testdata/complete.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# already has the relevant import required for the completion.

vim ex 'e main.go'
errlogwait 'PublishDiagnostics callback: &protocol.PublishDiagnosticsParams{\n\S+:\s+URI:\s+"file://'$WORK/main.go
vim ex 'call cursor(11,17)'
vim ex 'call feedkeys(\"i\\<C-X>\\<C-O>\\<C-N>\\<ESC>\", \"xt\")'
vim ex 'w'
Expand Down

0 comments on commit 4c35102

Please sign in to comment.