Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add macOS and Windows to build matrix #481

Open
myitcv opened this issue Sep 4, 2019 · 3 comments
Open

ci: add macOS and Windows to build matrix #481

myitcv opened this issue Sep 4, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@myitcv
Copy link
Member

myitcv commented Sep 4, 2019

Per discussion with @leitzler, we should add macOS to the build matrix in order to increase confidence for our macOS users. We're blind on that right now, and things like file watching (see #477) is OS-specific and sensitive.

  • likely want to keep Docker images for Linux builds; these serve as a useful means of quickly re-running tests without requiring the user to have Vim/Gvim build locally (https://github.com/myitcv/govim/wiki/govim-tests#running-tests---inside-docker)
  • likely want to move to GitHub actions after we have a working Travis setup with macOS. Less moving parts that way, slightly more mature setup on Travis, Travis macOS builders are quite fast. Again, we'd want to keep the Linux Docker approach even when we move to GitHub actions, in order that we dog-food that setup
  • you cannot have a macOS image (wrong type of kernel?) hence we would need to resort to building Vim, installing the right Go version for each macOS CI run. Not critical, but not ideal either. Perhaps not so much of an issue if we consider the macOS build matrix entries as more of a fail-safe (could for example configure them to only run on master)
@myitcv myitcv added the enhancement New feature or request label Sep 4, 2019
@myitcv myitcv added this to the Unplanned milestone Sep 4, 2019
@myitcv
Copy link
Member Author

myitcv commented Oct 19, 2019

As part of using GitHub actions we should use @rogpeppe's work on CUE schemas:

https://github.com/heetch/cue-schema/tree/master/github/actions

@myitcv myitcv changed the title ci: add macOS to build matrix ci: add macOS and Windows to build matrix Jan 31, 2020
@myitcv
Copy link
Member Author

myitcv commented Jan 31, 2020

In 59ef3d6 we moved to GitHub actions. Now we should really add macOS and Windows. But they don't need to be full-blown suites like on Linux - that can (and should) remain Docker-based.

Just something that:

@myitcv
Copy link
Member Author

myitcv commented Jan 31, 2020

For Windows support we will need to investigate something like https://pkg.go.dev/github.com/containerd/console?tab=doc as an alternative to our current PTY package.

myitcv added a commit that referenced this issue Jan 31, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Jan 31, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Jan 31, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Feb 1, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Feb 1, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Feb 10, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Feb 10, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Feb 10, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim. We can update this to be more specific later.

Updates #481
myitcv added a commit that referenced this issue Feb 10, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
myitcv added a commit that referenced this issue Feb 10, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later. For
now neither capture nor upload any artefacts post build.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
myitcv added a commit that referenced this issue Feb 10, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later. For
now neither capture nor upload any artefacts post build.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
myitcv added a commit that referenced this issue Feb 11, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later. For
now neither capture nor upload any artefacts post build.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
myitcv added a commit that referenced this issue Feb 11, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later. For
now neither capture nor upload any artefacts post build.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
myitcv added a commit that referenced this issue Feb 11, 2020
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later. For
now neither capture nor upload any artefacts post build.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant