Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: first cut of running tests on macOS #746

Merged
merged 1 commit into from
Feb 11, 2020
Merged

ci: first cut of running tests on macOS #746

merged 1 commit into from
Feb 11, 2020

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Jan 31, 2020

No description provided.

@myitcv myitcv force-pushed the ci_macos_windows branch 3 times, most recently from 4c920d1 to 939977d Compare January 31, 2020 06:30
@myitcv myitcv changed the title ci: first cut of running tests on macOS and Windows ci: first cut of running tests on macOS Jan 31, 2020
@myitcv myitcv force-pushed the ci_macos_windows branch 3 times, most recently from 857050d to cc717b8 Compare January 31, 2020 07:24
@myitcv myitcv requested a review from leitzler January 31, 2020 07:30
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment about version (the commit message refers to latest vim).

internal/cmd/genconfig/genconfig.go Outdated Show resolved Hide resolved
@myitcv myitcv force-pushed the ci_macos_windows branch 2 times, most recently from 5683ebb to 0ea0356 Compare February 1, 2020 08:22
@myitcv myitcv force-pushed the ci_macos_windows branch 6 times, most recently from 3eb5bb2 to 3ea90fb Compare February 10, 2020 14:39
@myitcv myitcv requested a review from leitzler February 10, 2020 14:39
@myitcv
Copy link
Member Author

myitcv commented Feb 10, 2020

@leitzler - I've updated this to not use a third-party GitHub action (per the "advice" in https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html). Instead we use a local pure Go action. Perhaps you could give it a look?

Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent to get started with macOS as well, LGTM! Also with a go action, that's really nice. Future PR's should at least include artefact uploads.

.github/workflows/test.yml Show resolved Hide resolved
github/actions/setupvim/go.mod Outdated Show resolved Hide resolved
github/actions/setupvim/README.md Outdated Show resolved Hide resolved
Get a simple version of our tests running against "latest" Go and
"latest" Vim on macOS. We can update this to be more specific later. For
now neither capture nor upload any artefacts post build.

To install Vim we follow the approach laid out in:

    https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html

to create a local pure Go GitHub action to install Vim, rather than
relying on a third-party NodeJS action.

Updates #481
@myitcv
Copy link
Member Author

myitcv commented Feb 11, 2020

Thanks for taking a look.

Future PR's should at least include artefact uploads.

Yes, that should be relatively straightforward using _scripts/captureLogs.sh

@myitcv myitcv merged commit 9925c13 into master Feb 11, 2020
@myitcv myitcv deleted the ci_macos_windows branch February 11, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants