-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: first cut of running tests on macOS #746
Conversation
4c920d1
to
939977d
Compare
857050d
to
cc717b8
Compare
cc717b8
to
35c00a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment about version (the commit message refers to latest vim).
5683ebb
to
0ea0356
Compare
3eb5bb2
to
3ea90fb
Compare
@leitzler - I've updated this to not use a third-party GitHub action (per the "advice" in https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html). Instead we use a local pure Go action. Perhaps you could give it a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent to get started with macOS as well, LGTM! Also with a go action, that's really nice. Future PR's should at least include artefact uploads.
3ea90fb
to
35bd3ac
Compare
Get a simple version of our tests running against "latest" Go and "latest" Vim on macOS. We can update this to be more specific later. For now neither capture nor upload any artefacts post build. To install Vim we follow the approach laid out in: https://blog.myitcv.io/2020/02/04/portable-ci-cd-with-pure-go-github-actions.html to create a local pure Go GitHub action to install Vim, rather than relying on a third-party NodeJS action. Updates #481
35bd3ac
to
08e7ddd
Compare
Thanks for taking a look.
Yes, that should be relatively straightforward using |
No description provided.