Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/govim: add directory filtering to darwin file watcher #1038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cmd/govim: add directory filtering to darwin file watcher #1038

wants to merge 1 commit into from

Commits on Feb 9, 2021

  1. cmd/govim: add directory filtering to darwin file watcher 

    The file watcher in darwin is recursive so adding and removing
directories to watch was no-ops. One issue with that was that the
filtering in cmd/govim/watcher.go that made sure files in directories
that starts with '.' or '_' wasn't watched didn't apply in darwin.

A consequence of that was that the test suite failed on darwin.

We now apply a simple filter to added paths and suppress events for
files outside those. Note that we do want to filter rather than
configuring the file watcher to be non-recursive to avoid #492.
    @leitzler
    leitzler committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    193467c View commit details
    Browse the repository at this point in the history