Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/govim: add test for quickfix errors in dependencies #326

Merged
merged 1 commit into from
Jan 21, 2020
Merged

cmd/govim: add test for quickfix errors in dependencies #326

merged 1 commit into from
Jan 21, 2020

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Jun 29, 2019

No description provided.

@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch from 51ac8b5 to f742902 Compare July 14, 2019 08:04
@myitcv myitcv added this to the Unplanned milestone Jul 14, 2019
@myitcv myitcv added the onhold Probably pending some 3rd party issue label Sep 24, 2019
@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch 3 times, most recently from ba3c6ec to 1180122 Compare December 2, 2019 12:50
@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch 7 times, most recently from 447e798 to dc248fb Compare December 12, 2019 11:47
@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch 5 times, most recently from 992b16b to 9fd2440 Compare December 16, 2019 12:10
@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch 2 times, most recently from 86ce6d9 to c7ad85f Compare December 22, 2019 15:43
@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch from c7ad85f to ace1147 Compare January 20, 2020 13:40
@myitcv myitcv changed the title [WIP] cmd/govim: add test for quickfix errors in dependencies cmd/govim: add test for quickfix errors in dependencies Jan 20, 2020
@myitcv myitcv removed the onhold Probably pending some 3rd party issue label Jan 20, 2020
@myitcv myitcv modified the milestones: Unplanned, Next Jan 20, 2020
@myitcv myitcv requested a review from leitzler January 20, 2020 13:40
leitzler
leitzler approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two questions

_scripts/runDockerRun.sh Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
@myitcv myitcv mentioned this pull request Jan 21, 2020
Merged
@myitcv myitcv force-pushed the cmd_govim_quickfix_dependency_error branch from ace1147 to 4533cd6 Compare January 21, 2020 06:09
@myitcv myitcv merged commit 921c364 into master Jan 21, 2020
@myitcv myitcv deleted the cmd_govim_quickfix_dependency_error branch January 21, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leitzler leitzler leitzler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myitcv @leitzler