cmd/govim: make testscript scripts truly concurrent #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our cmd/govim testscript tests are split across a number of directories. This grouping allows us to have separate configuration per directory. Currently we do not call t.Parallel in each directory's subtest. This means that we run directory scipts in serial, one directory after another. Therefore, if there is a particularly slow test in one directory, we can end up with flat spots where we do not fully utilise the -test.parallel concurrency limit. Making directory subtests parallel removes these flat spots. But we do so at the cost of leaving beind gopls install artefacts. When we start testing against a Go 1.14 release that includes CL 214822 we can enable that cleanup, but Go version pre 1.14 will unfortunately continue to leak these artefacts.
myitcv
force-pushed
the
tests_parallel_subtests
branch
from
881c5a5
to
2cc5129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cmd/govim testscript tests are split across a number of directories.
This grouping allows us to have separate configuration per directory.
Currently we do not call t.Parallel in each directory's subtest. This
means that we run directory scipts in serial, one directory after
another. Therefore, if there is a particularly slow test in one
directory, we can end up with flat spots where we do not fully utilise
the -test.parallel concurrency limit.
Making directory subtests parallel removes these flat spots. But we do
so at the cost of leaving beind gopls install artefacts. When we start
testing against a Go 1.14 release that includes CL 214822 we can enable
that cleanup, but Go version pre 1.14 will unfortunately continue to
leak these artefacts.