Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/govim: provide GOVIMGoImports and GOVIMGoFmt range commands #42

Merged
merged 1 commit into from May 3, 2019

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Mar 29, 2019

All tests of format-on-save via gofmt and GOVIMGoFmt (remain) skipped
pending golang/go#31759

The tests of range-based GOVIMGoImports and GOVIMGoFmt are skipped
pending golang/go#31150

@myitcv myitcv force-pushed the range_formatting_commands branch 3 times, most recently from a03fd25 to 26b61f8 Compare April 7, 2019 09:18
@myitcv
Copy link
Member Author

myitcv commented Apr 7, 2019

Currently blocked on golang/go#31150

@myitcv myitcv added the onhold Probably pending some 3rd party issue label Apr 7, 2019
@myitcv myitcv force-pushed the range_formatting_commands branch 4 times, most recently from 087de0d to e947e59 Compare May 3, 2019 12:55
All tests of format-on-save via gofmt and GOVIMGoFmt (remain) skipped
pending golang/go#31759

The tests of range-based GOVIMGoImports and GOVIMGoFmt are skipped
pending golang/go#31150
@myitcv myitcv force-pushed the range_formatting_commands branch from e947e59 to 0d56ef9 Compare May 3, 2019 13:00
@myitcv myitcv changed the title [WIP] cmd/govim: provide GOVIMGoImports and GOVIMGoFmt range commands cmd/govim: provide GOVIMGoImports and GOVIMGoFmt range commands May 3, 2019
@myitcv
Copy link
Member Author

myitcv commented May 3, 2019

Added skips for now to bypass issues created by golang/go#31759 and golang/go#31150

@myitcv myitcv merged commit 954a4c3 into master May 3, 2019
@myitcv myitcv deleted the range_formatting_commands branch May 3, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onhold Probably pending some 3rd party issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant