cmd/govim: add concept of user config in test overrides #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_tests_user_config
branch
4 times, most recently
from
9020990
to
bb54cf3
Compare
Currently in our script tests we can specify the default config values that will be used in the test. This overrides the cmd/govim default that the end user will experience. Whilst this might be necessary in some limited test situations, it's generally not what we neeed/intend. Rather any config we're looking to supply in a scenario is generally an initial override for the cmd/govim default. Hence, we now all a test script to specify an explicit default via default_config.json in a scenario directory (which would be nil, i.e. no file), and we also allow for user_config.json to be the user's initial overrides that are applied atop the defaults (whatever they may be). As part of this we write a simple code generator to automate the creation of the method: (*cmd/govim/config.Config).Apply(*cmd/govim/config.Config) to avoid human mistakes further down the line.
myitcv
force-pushed
the
cmd_govim_tests_user_config
branch
from
bb54cf3
to
153d7a9
Compare
leitzler
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.