Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/govim: use github.com/rogpeppe/go-internal/gotooltest in tests #639

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Dec 21, 2019

No description provided.

@myitcv myitcv force-pushed the cmd_govim_use_gotooltest_in_testscript_tests branch from 9e931cd to 7a4ef57 Compare December 21, 2019 16:17
@myitcv myitcv requested a review from leitzler December 21, 2019 16:18
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use github.com/rogpeppe/go-internal/gotooltest in testscript tests to
make it easier to use cmd/go (no 'exec go' required) and Go version
conditions (e.g. [!go.14] runs a command for all Go versions < 1.14)
@myitcv myitcv force-pushed the cmd_govim_use_gotooltest_in_testscript_tests branch from 7a4ef57 to 5bbb9f3 Compare December 22, 2019 07:01
@myitcv myitcv merged commit 8201bdf into master Dec 22, 2019
@myitcv myitcv deleted the cmd_govim_use_gotooltest_in_testscript_tests branch December 22, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants