cmd/govim: persist highlights for explicit GOVIMHighlightReferences call #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_persist_references_highlight
branch
from
7ace240
to
91e1da2
Compare
leitzler
approved these changes
Apr 12, 2020
myitcv
force-pushed
the
cmd_govim_persist_references_highlight
branch
from
91e1da2
to
b61398b
Compare
When manually invoking GOVIMHighlightReferences, it makes sense to persist the highlights for as long as we can. To be safe we assume that making any change to any .go file will potentially invalidate the highlighted references (we might relax this at a later stage). We also add the GOVIMClearReferencesHighlights command to explicitly remove the highlights. As part of this same commit we: * move the definition of currentReferences to vimstate where it belongs (it is only ever accessed on the vimstate "thread") * Tidy up and simplify some logic regarding removal of highlights
myitcv
force-pushed
the
cmd_govim_persist_references_highlight
branch
from
b61398b
to
e9f282d
Compare
myitcv
added a commit
that referenced
this pull request
Apr 13, 2020
In 3139f79 I incorrectly removed all reference highlights when a delta is received. However, the logic prior to that change was that highlights would only be moved (even in insert mode) if the cursor falls outside of a highlighted range. Therefore, we adopt exactly the logic that @leitzler proposed in #852 to only remove highlights on delta if we are in manual highlighting mode.
myitcv
added a commit
that referenced
this pull request
Apr 13, 2020
…857) In 3139f79 I incorrectly removed all reference highlights when a delta is received. However, the logic prior to that change was that highlights would only be moved (even in insert mode) if the cursor falls outside of a highlighted range. Therefore, we adopt exactly the logic that @leitzler proposed in #852 to only remove highlights on delta if we are in manual highlighting mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manually invoking GOVIMHighlightReferences, it makes sense to
persist the highlights for as long as we can. To be safe we assume that
making any change to any .go file will potentially invalidate the
highlighted references (we might relax this at a later stage). We also
add the GOVIMClearReferencesHighlights command to explicitly remove the
highlights.
As part of this same commit we:
(it is only ever accessed on the vimstate "thread")