OLH-1904 Fix CFN-lint errors on template.yaml

govuk-one-login · Jun 21, 2024 · ae01178 · ae01178
1 parent 358dee1
commit ae01178
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/lint-cloudformation.yaml b/.github/workflows/lint-cloudformation.yaml
@@ -23,7 +23,7 @@ jobs:
           python-version: "3.x"
 
       - name: Install cfn-lint
-        run: python -m pip install cfn-lint
+        run: python -m pip install cfn-lint -r "eu-west-2"
 
       - name: Run linter
         run: cfn-lint template.yaml
diff --git a/template.yaml b/template.yaml
@@ -1590,8 +1590,6 @@ Resources:
 
   DeleteEmailSubscriptionsFunctionLogGroup:
     Type: AWS::Logs::LogGroup
-    DependsOn:
-      - DeleteEmailSubscriptionsFunction
     Properties:
       LogGroupName: !Sub "/aws/lambda/${DeleteEmailSubscriptionsFunction}"
       RetentionInDays: 30
@@ -3765,7 +3763,7 @@ Resources:
             Resource: "*"
           - Effect: Allow
             Principal:
-              Service: !Sub "secretsmanager.amazonaws.com"
+              Service: "secretsmanager.amazonaws.com"
             Action:
               - "kms:Encrypt*"
               - "kms:Decrypt*"