Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIWI-1744 - Athena Test Harness #168

Closed
wants to merge 29 commits into from
Closed

KIWI-1744 - Athena Test Harness #168

wants to merge 29 commits into from

Conversation

darrendunford
Copy link
Contributor

@darrendunford darrendunford commented Apr 5, 2024

Proposed changes

What changed

Implements a Test Harness function and API test to generate a partial match result, and check that the corresponding record is generated in S3 and retrievable via Athena.

Why did it change

Provide automated testing for Athena

Issue tracking

Checklists

PII logging

  • Verified that no PII data is being logged

Environment variables or secrets

  • No environment variables or secrets were added or changed

Other considerations

  • Update README with any new instructions or tasks

@darrendunford darrendunford marked this pull request as ready for review April 6, 2024 13:01
@darrendunford darrendunford requested review from a team as code owners April 6, 2024 13:01
src/tests/api/BavUnhappyPath.test.ts Outdated Show resolved Hide resolved
test-harness/src/AthenaQueryHandler.ts Show resolved Hide resolved
src/tests/api/BavUnhappyPath.test.ts Show resolved Hide resolved
test-harness/template.yaml Outdated Show resolved Hide resolved
mudassar-jafer
mudassar-jafer previously approved these changes May 21, 2024
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@darrendunford
Copy link
Contributor Author

replaced by #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants