removed conditional and modified RetentionInDays values to 30 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinosarenkhoe
had a problem deploying
to
development
GitHub Actions
Failure
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
|
kelvinosarenkhoe
had a problem deploying
to
development
GitHub Actions
Failure
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
kelvinosarenkhoe
temporarily deployed
to
development
GitHub Actions
Inactive
surajkumar
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase log group's RetentionInDays to 30. Currently any log retention that is set under 30 days will be set to 30 by a Lambda attached to the LZA Lambda run - INCIDEN-627
What changed
RetentionInDays: changed RetentionInDays: 30
Check ticket https://govukverify.atlassian.net/jira/software/c/projects/PSREC/boards/555?selectedIssue=PSREC-243 and associated epic https://govukverify.atlassian.net/browse/PSREC-314
Why did it change
LZA lambda unpicks log retentions lower than 30 days.
Issue tracking
INCIDEN-627
Environment variables or secrets
[ ] No environment variables or secrets were added or changed
[ ] Documented in the https://github.com/govuk-one-login/ipv-cri-check-hmrc-api/blob/main/infrastructure/README.md
[ ] Added to deployment steps
[ ] Added to local startup config
Other considerations
[ ] Update [https://github.com/govuk-one-login/ipv-cri-check-hmrc-api/blob/main/infrastructure/README.md] with any new instructions or tasks