Bugfix/loading box dependency #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint needs to be configured to pick up exports that aren't in package.json see import-js/eslint-plugin-import#1049 In the meantime we are including @govuk-react/storybook as a dependency, which will help ensure subdependencies are included.
stevesims
reviewed
Apr 6, 2018
| @@ -33,6 +33,7 @@ | |||
| "@govuk-react/related-items": "^0.1.25", | |||
| "@govuk-react/search-box": "^0.1.25", | |||
| "@govuk-react/select": "^0.1.25", | |||
| "@govuk-react/storybook": "^0.1.25", | |||
There was a problem hiding this comment.
you haven't added @govuk-react/loading-box to this file...
stevesims
reviewed
Apr 6, 2018
| "@govuk-react/label-text": "^0.1.25", | ||
| "@govuk-react/list-item": "^0.1.25", | ||
| "@govuk-react/list-navigation": "^0.1.25", | ||
| "@govuk-react/multi-choice": "^0.1.25", |
There was a problem hiding this comment.
think we should add in loading-box here
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 44 44
Lines 299 299
Branches 8 8
=====================================
Hits 299 299Continue to review full report at Codecov.
|
stevesims
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@govuk-react/loading-boxwasn't a sub dependency of govuk-react. We want issues like this to be picked up automatically.eslint needs to be configured to pick up exports that aren't in package.json, but this can't be done right now, see import-js/eslint-plugin-import#1049.
In the meantime we are including @govuk-react/storybook as a dependency, which will help ensure the storybook sub dependencies are included.
Also: