New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/loading box dependency #189
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8f35a90
remove package lock, using yarn as standard
penx 96bbb40
update yarn lock
penx 0cd91ea
remove loading box package lock
penx 193b72a
fix to eslint command to include subfolders of src
penx 4620b74
hoc devDependencies
penx b5f4b70
storybook dependencies
penx 4d9ce93
@govuk-react/storybook as dependency of govuk-react (temporary)
penx cb00d34
loading-box as dependency of govuk-react
penx 3612e24
don't run eslint on node_modules on travis
penx File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,35 @@ | |
}, | ||
"devDependencies": { | ||
"@babel/cli": "^7.0.0-beta.40", | ||
"@govuk-react/back-link": "^0.1.25", | ||
"@govuk-react/breadcrumb": "^0.1.25", | ||
"@govuk-react/button": "^0.1.25", | ||
"@govuk-react/checkbox": "^0.1.25", | ||
"@govuk-react/date-input": "^0.1.25", | ||
"@govuk-react/error-text": "^0.1.25", | ||
"@govuk-react/file-upload": "^0.1.25", | ||
"@govuk-react/header": "^0.1.25", | ||
"@govuk-react/hint-text": "^0.1.25", | ||
"@govuk-react/input": "^0.1.25", | ||
"@govuk-react/input-field": "^0.1.25", | ||
"@govuk-react/label": "^0.1.25", | ||
"@govuk-react/label-text": "^0.1.25", | ||
"@govuk-react/list-item": "^0.1.25", | ||
"@govuk-react/list-navigation": "^0.1.25", | ||
"@govuk-react/multi-choice": "^0.1.25", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. think we should add in |
||
"@govuk-react/ordered-list": "^0.1.25", | ||
"@govuk-react/pagination": "^0.1.25", | ||
"@govuk-react/panel": "^0.1.25", | ||
"@govuk-react/phase-badge": "^0.1.25", | ||
"@govuk-react/phase-banner": "^0.1.25", | ||
"@govuk-react/radio": "^0.1.25", | ||
"@govuk-react/related-items": "^0.1.25", | ||
"@govuk-react/search-box": "^0.1.25", | ||
"@govuk-react/select": "^0.1.25", | ||
"@govuk-react/text-area": "^0.1.25", | ||
"@govuk-react/unordered-list": "^0.1.25", | ||
"@storybook/addon-actions": "^3.3.14", | ||
"@storybook/addon-knobs": "^3.4.0", | ||
"@storybook/react": "^3.3.14", | ||
"cross-env": "^5.1.4", | ||
"enzyme": "^3.3.0", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you haven't added
@govuk-react/loading-box
to this file...