Java 11 Ready To Go

[goxr3plus]

@HelgeStenstrom @TonalidadeHidrica

Here is Java 11 Version => Java 11 Branch which i have changed everything to be compatible with Java 11 .

I can't run it though ... i don't know what is the problem .

Please help :)!!!!!

[HelgeStenstrom]

I'm as new with Java-11 as you are. But I think module-info.java is put in the wrong place, and that it should be in the source tree, not in the resource tree. But it right under src/main/java. I did so. had to add requires java.logging; but got the problems with Error:java: module XR3Capture reads package org.tritonus.share.sampled.mixer from both tritonus.all and tritonus.share haven't investigated further. /Helge Den mån 20 maj 2019 kl 16:54 skrev GOXR3PLUS STUDIO < notifications@github.com>:

…

@HelgeStenstrom <https://github.com/HelgeStenstrom> @TonalidadeHidrica <https://github.com/TonalidadeHidrica> Here is Java 11 Version => [ https://github.com/goxr3plus/XR3Player/tree/Java-11] which i have changed everything to be compatible with Java 11 . I can't run it though ... i don't know what is the problem . Please help :)!!!!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AABJLY7ZU4MMNUHDO5SR33DPWK3TPA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUX425A>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJLYYZNFQBSO62FOKGQJ3PWK3TPANCNFSM4HOCY3PQ> .

[goxr3plus]

Thank you very much i will investigate too :)

…

On Tue, 28 May 2019, 09:08 Helge Stenström, ***@***.***> wrote: I'm as new with Java-11 as you are. But I think module-info.java is put in the wrong place, and that it should be in the source tree, not in the resource tree. But it right under src/main/java. I did so. had to add requires java.logging; but got the problems with Error:java: module XR3Capture reads package org.tritonus.share.sampled.mixer from both tritonus.all and tritonus.share haven't investigated further. /Helge Den mån 20 maj 2019 kl 16:54 skrev GOXR3PLUS STUDIO < ***@***.***>: > @HelgeStenstrom <https://github.com/HelgeStenstrom> @TonalidadeHidrica > <https://github.com/TonalidadeHidrica> > > Here is Java 11 Version => [ > https://github.com/goxr3plus/XR3Player/tree/Java-11] which i have changed > everything to be compatible with Java 11 . > > I can't run it though ... i don't know what is the problem . > > Please help :)!!!!! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #17?email_source=notifications&email_token=AABJLY7ZU4MMNUHDO5SR33DPWK3TPA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUX425A >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AABJLYYZNFQBSO62FOKGQJ3PWK3TPANCNFSM4HOCY3PQ > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AE3OFQGXU3GZ5FL2KNVEMNDPXTD5ZA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWLCA5A#issuecomment-496377972>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3OFQH7NW7ZUSOC4IVHEILPXTD5ZANCNFSM4HOCY3PQ> .

[goxr3plus]

@HelgeStenstrom I updated the Java11 branch and removed tritonous-share and also moved module-info.java and added requires java.logging; .

Please make a merge and let me know :) .

Don't forget that you can directly commit on the branch Java11 in this repository :)

[goxr3plus]

@HelgeStenstrom Resolved all the problems you had => https://github.com/goxr3plus/XR3Player/tree/Java-11 now we have a new problem with Jave2 dependency and i opened an issue to the Jave2 Repository .

I am also a collaborator to that repository so i can make changes , tell me if you can help :) .

I am getting more confortable with Java11 and i see XR3Player passing soon in Java11/12/13.

[goxr3plus]

@HelgeStenstrom I died in front of the screen , managed to make it play , though i have disabled web-browser because i get a strange error about reflection which i don't know how to solve yet .

Feel free to try it :) , XR3Player just fully runned on Java 11 .

Please don't forget to add those as VM Parameters =>

--add-exports javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix
--add-exports javafx.controls/com.sun.javafx.scene.control=com.jfoenix
--add-exports javafx.base/com.sun.javafx.binding=com.jfoenix
--add-exports javafx.graphics/com.sun.javafx.stage=com.jfoenix
--add-exports javafx.base/com.sun.javafx.event=com.jfoenix

because JFoenix is not fully capable of Java 9 .

[goxr3plus]

@HelgeStenstrom Merged everything to master , now it's oficially running on JDK 11 and soon on JDK 12 and 13.

I have a problem with the Reflections , i can't get it working . It's a trick in order to bypass JxBrowser license , even though i have a license i don't want to bother everytime with a new one .

So i am using Reflection in order to bypass , but on Java 11 i don't know why it throws errors i can't use Field and stuff like that :( .

Can you help me ?

Also if you want to run the project please read the instructions .

[goxr3plus]

@HelgeStenstrom We just passed in Java 12 with the latest commit . Ah i can't get that reflection work ... ah Java damnnnn .

And don't want to go again through the procedure of getting a license for JxBrowser .

[HelgeStenstrom]

I don't have Java 12 installed. Perhaps I will get it.
What is it that requires Java 12, except the pom.xml file?

[goxr3plus]

Inside thr pom inhave added JavaFX 12.

…

On Tue, 11 Jun 2019, 00:43 Helge Stenström, ***@***.***> wrote: I don't have Java 12 installed. Perhaps I will get it. What is it that requires Java 12, except the pom.xml file? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AE3OFQHYCRT6TG2TAAR47EDPZ3DGZA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLKLMQ#issuecomment-500606386>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3OFQAEHO5M54TCQLMGOW3PZ3DGZANCNFSM4HOCY3PQ> .

[HelgeStenstrom]

So if I change back to Java 11 in the pom.xml file, I can use Java 11? There is no particular feature of Java 12 that you are using in the project? Den tis 11 juni 2019 kl 07:22 skrev GOXR3PLUS STUDIO < notifications@github.com>:

…

Inside thr pom inhave added JavaFX 12. On Tue, 11 Jun 2019, 00:43 Helge Stenström, ***@***.***> wrote: > I don't have Java 12 installed. Perhaps I will get it. > What is it that requires Java 12, except the pom.xml file? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #17?email_source=notifications&email_token=AE3OFQHYCRT6TG2TAAR47EDPZ3DGZA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLKLMQ#issuecomment-500606386 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AE3OFQAEHO5M54TCQLMGOW3PZ3DGZANCNFSM4HOCY3PQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AABJLYZ73CYRS47HLL6RCZDPZ4Y73A5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXL7API#issuecomment-500691005>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJLY2TI6STKMN3HNBNWTDPZ4Y73ANCNFSM4HOCY3PQ> .

[goxr3plus]

Java 12 comes with performance improvements and other stuff. Yes id you return the pom you can run it with Java 11. Change every 12 to 11, special care check frok Maven central the latest JavaFX 11 version I think it's 11.0.2 On Tue, 11 Jun 2019, 10:49 Helge Stenström, <notifications@github.com> wrote:

…

So if I change back to Java 11 in the pom.xml file, I can use Java 11? There is no particular feature of Java 12 that you are using in the project? Den tis 11 juni 2019 kl 07:22 skrev GOXR3PLUS STUDIO < ***@***.***>: > Inside thr pom inhave added JavaFX 12. > > On Tue, 11 Jun 2019, 00:43 Helge Stenström, ***@***.***> > wrote: > > > I don't have Java 12 installed. Perhaps I will get it. > > What is it that requires Java 12, except the pom.xml file? > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > < > #17?email_source=notifications&email_token=AE3OFQHYCRT6TG2TAAR47EDPZ3DGZA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLKLMQ#issuecomment-500606386 > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AE3OFQAEHO5M54TCQLMGOW3PZ3DGZANCNFSM4HOCY3PQ > > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #17?email_source=notifications&email_token=AABJLYZ73CYRS47HLL6RCZDPZ4Y73A5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXL7API#issuecomment-500691005 >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AABJLY2TI6STKMN3HNBNWTDPZ4Y73ANCNFSM4HOCY3PQ > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AE3OFQBGP2TOHKZ5PXXBQ3LPZ5KHRA5CNFSM4HOCY3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXMIDRQ#issuecomment-500728262>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3OFQHAO5373ECOGYCF5XDPZ5KHRANCNFSM4HOCY3PQ> .

[goxr3plus]

Closing this as done i think .