ColorIndex in Oscilloscope, why?

[HelgeStenstrom]

XR3Player/src/main/java/com/goxr3plus/xr3player/xplayer/visualizer/geometry/Oscilloscope.java

Line 139 in 7e90aa4

colorIndex = (colorIndex == colorSize - 1) ? 0 : colorIndex + 1;

would be simpler expressed (I haven't tested) as

colorIndex = colorIndex++ % colorSize;

But what it the purpose of updating colorIndex?

[goxr3plus]

Oh you are digging into the madness of Visualizer, would you believe me if i tell you i have written this code during 15 hours straight coding :)?

I think i am changing the colors of the line based on something.

I plan to make it a separate library which is not part of XR3Player code, so we will have multiple modules.

[goxr3plus]

Did you manage to run XR3Player on Java 11? I am having problems after starting it on making amplitudes work, Jave2 library is not exporting the FFMPEG correctly.

Ah i will fix everything, i watched 11. 5hours tutorials for Java 9 JPMS modular system.

[HelgeStenstrom]

I haven't really tried yet. I tried and failed before I learned that I have to supply some VM arguments, but haven't done so.

[goxr3plus]

Yyes without VM arguments it can not run. By the way installing Java 12 is like too easy and you don't really have to change anything in IntelliJ.

…

On Fri, 14 Jun 2019, 08:36 Helge Stenström, ***@***.***> wrote: Closed #18 <#18>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AE3OFQD26AVRYZ3HUI625XLP2MU4TA5CNFSM4HX7MPPKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR7GVB7A#event-2412597500>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3OFQERERFANJW4ZPDKC7LP2MU4TANCNFSM4HX7MPPA> .

[HelgeStenstrom]

Did you pick Java 12 from Oracle or from https://openjdk.java.net?

[goxr3plus]

From Oracle but i think OpenJDK with work too.

…

On Fri, 14 Jun 2019, 20:53 Helge Stenström, ***@***.***> wrote: Did you pick Java 12 from Oracle or from https://openjdk.java.net? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AE3OFQAIJR4ZPAGXD6ZAYK3P2PLKHA5CNFSM4HX7MPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXQT7I#issuecomment-502204925>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3OFQEQITTGY7HFF4PG5TLP2PLKHANCNFSM4HX7MPPA> .

[HelgeStenstrom]

I did it, have Java 12 now.

[goxr3plus]

Glad to hear :) Let me know your opinion when you finally run it :)