Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit testing #59

Merged
merged 4 commits into from
Dec 22, 2019
Merged

Conversation

HelgeStenstrom
Copy link
Collaborator

Description

Improved and more complete unit tests.

StreamPlayerMethodsTest still contains tests that don't pass. The tested methods are candidates for removal from StreamPlayer.

All tests in StreamPlayerMethodsTest must be reviewed: Do they actually verify anything that need to be verified? Or are they too coupled with the current implementation?

StreamPlayerFutureImprovementTest contains tests that currently fail. Failures are caused by behavior in StreamPlayer which I think is wrong or bad. But I may have misinterpreted the intended behavior.

This PR doesn't add any dependencies.

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update
  • Refactor
  • Build-related changes
  • This change requires a documentation update
  • Other, please describe: Unit tests

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Has This Been Tested?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Some unit tests are improved, but there are more to be done.
StreamPlayerMethodsTest still contains tests that don't pass. The tested methods are candidates for removal from StreamPlayer.

All tests in StreamPlayerMethodsTest must be reviewed: Do they actually verify anything that need to be verified? Or are they too coupled with the current implementation?

StreamPlayerFutureImprovementTest contains tests that currently fail. Failures are caused by behavior in StreamPlayer which I think is wrong or bad. But I may have misinterpreted the intended behavior.
@goxr3plus
Copy link
Owner

Thank you, i have reviewed your code and merging.

I have seen your other issues i will reply to one by one, it's that i am very busy with the company i am working and i didn't had much time, thank you ♥

@goxr3plus goxr3plus merged commit 2905d6e into goxr3plus:master Dec 22, 2019
@HelgeStenstrom HelgeStenstrom deleted the improveUnitTesting branch December 22, 2019 18:21
@HelgeStenstrom
Copy link
Collaborator Author

Although unit tests are harmless in themselves, this PR needs reviewing.

@goxr3plus
Copy link
Owner

I had a good look from my mobile on all the 3 files changed, it's just i don't have an option from the app to accept the review code, i can directly merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants