Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit testing #59

Merged
merged 4 commits into from
Dec 22, 2019
Merged

Improve unit testing #59

merged 4 commits into from
Dec 22, 2019

Commits on Dec 18, 2019

  1. minor JavaDoc and readability improvement

    @HelgeStenstrom
    HelgeStenstrom committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    719d370 View commit details
    Browse the repository at this point in the history

  2. Update StreamPlayerMethodsTest.java 

    Some unit tests are improved, but there are more to be done.
    @HelgeStenstrom
    HelgeStenstrom committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    0ef3d2f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Improved and re-structured unit tests

    @HelgeStenstrom
    HelgeStenstrom committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    68c67ca View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. Improved and more complete unit tests. 

    StreamPlayerMethodsTest still contains tests that don't pass. The tested methods are candidates for removal from StreamPlayer.

All tests in StreamPlayerMethodsTest must be reviewed: Do they actually verify anything that need to be verified? Or are they too coupled with the current implementation?

StreamPlayerFutureImprovementTest contains tests that currently fail. Failures are caused by behavior in StreamPlayer which I think is wrong or bad. But I may have misinterpreted the intended behavior.
    @HelgeStenstrom
    HelgeStenstrom committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    dca8c7a View commit details
    Browse the repository at this point in the history