Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply Random ID to AddItem #116

Closed
yauj opened this issue Aug 2, 2021 · 0 comments · Fixed by #146
Closed

Supply Random ID to AddItem #116

yauj opened this issue Aug 2, 2021 · 0 comments · Fixed by #146
Assignees
@Russell500
Labels
task Development Tasks
Milestone
Auto-Generate Ite...

Comments

@yauj
Copy link
Member

yauj commented Aug 2, 2021

Story Points: [1]

How?

  • Remove id from AddItemInput
  • Auto-supply the ID field to the ItemTable.create field.
    • Fix AddItem Tests to accommodate this change.
      • Mock the method, to force ID to be a certain thing for tests.
  • Remove out the ability to supply the ID in the router.
    • Fix Router Tests to accommodate this change.
      • Mock the method, to force ID to be a certain thing for tests.
@yauj yauj added the task Development Tasks label Aug 2, 2021
@yauj yauj added this to the Auto-Generate Item ID milestone Aug 2, 2021
yauj added a commit that referenced this issue Aug 8, 2021
@yauj
GH-116: Auto-Supply ID during AddItem
a8b5ded
@yauj yauj mentioned this issue Aug 8, 2021
Merged
@yauj yauj closed this as completed in #146 Aug 9, 2021
yauj added a commit that referenced this issue Aug 9, 2021
@yauj
GH-116: Auto-Supply ID during AddItem
1889c53
NavigSB pushed a commit that referenced this issue Aug 9, 2021
@johnnyhchen @NavigSB
GH-54: Create a new GraphQL schema
a837947 
GH-131: Fix ItemTable key

GH-133: Update key for items table

GH-127: Added Action Dialog

* GH-127: Added Action Dialog

* GH-127: Dim background attempt

* GH-127: Added Action Dialog

* GH-127: Added Action Dialog

* GH-127: Added Action Dialog

* GH-127: Added Action Dialog

* GH-127: Added Action Dialog

* GH-127: Added Action Dialog

* GH-127: Fixing errors

* GH-127: Revisions

GH-115: Create method in AddItem to auto-generate the ID (#142)

GH-121: Function Integration Tests (#141)

* GH-121: Functions Integration Tests

GH-143: Change History item id to be called itemId

* GH-143: Change History item id to be called itemId

* Update seeds to let tests pass

GH-20: Move ts-code outside of amplify/backend directory

- Because that directory gets overidden on git pull
- Also Integration test after amplify push

GH-116: Auto-Supply ID during AddItem

Created functional tab navigation system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Russell500 Russell500

Labels
task Development Tasks
Projects
None yet
Milestone
Auto-Generate Item ID
Development

Successfully merging a pull request may close this issue.

GH-116: Auto-Supply ID during AddItem gp-seattle/rms-app
2 participants
@yauj @Russell500