Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 54/johnnyhchen #130

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Gh 54/johnnyhchen #130

merged 1 commit into from
Aug 5, 2021

Conversation

johnnyhchen
Copy link
Collaborator

Resolves #54

@johnnyhchen johnnyhchen temporarily deployed to AmplifyCD August 4, 2021 23:48 Inactive
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 93.77% 949/1012
🟢 Branches 94.49% 257/272
🟢 Functions 91.67% 330/360
🟢 Lines 93.77% 1174/1252

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 7f5c54b

@johnnyhchen johnnyhchen temporarily deployed to AmplifyCD August 5, 2021 00:01 Inactive
@johnnyhchen johnnyhchen temporarily deployed to AmplifyCD August 5, 2021 00:12 Inactive
@johnnyhchen johnnyhchen temporarily deployed to AmplifyCD August 5, 2021 00:20 Inactive
amplify/backend/api/rms/schema.graphql Outdated Show resolved Hide resolved
amplify/backend/api/rms/schema.graphql Outdated Show resolved Hide resolved
amplify/backend/api/rms/schema.graphql Outdated Show resolved Hide resolved
amplify/backend/api/rms/schema.graphql Outdated Show resolved Hide resolved
@johnnyhchen johnnyhchen temporarily deployed to AmplifyCD August 5, 2021 15:57 Inactive
@johnnyhchen johnnyhchen temporarily deployed to AmplifyCD August 5, 2021 16:19 Inactive
@johnnyhchen johnnyhchen merged commit 8164c1c into master Aug 5, 2021
@johnnyhchen
Copy link
Collaborator Author

Desirable

  • GraphQL Schema defined correctly and set up as an AppSync API
  • DynamoDB Tables properly added as datasources in AppSync
  • Get whole table queries will work and are connected to the proper resolver & DynamoDB DataSource
    Neutral
  • Autogenerated DynamoDB tables still exist in DynamoDB
    • Possible fix: Can delete these using console but might come back every time a new Amplify CD deployment script is run
  • The permissions given in the PolicyDocument section of CustomResources.json could possibly be refined. Can look into which Actions are necessary to pull a table from DynamoDB and add it to AppSync as a DataSource
    Not Desirable
  • All other queries do not have the proper resolver set up and will query from the auto-generated/wrong table
  • Not sure if string sets will be returned for certain desired fields or string arrays. We want string sets. Need to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS Amplify: Datastore] Create a new GraphQL schema to match existing database schema structure
2 participants