Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncompressed generation / decode of single channel images produces corrupted results in row and tile interleave modes #2704

Closed
3 tasks done
bradh opened this issue Dec 15, 2023 · 2 comments

Comments

@bradh
Copy link
Contributor

bradh commented Dec 15, 2023

Thanks for reporting your issue. Please make sure these boxes are checked before submitting your issue - thank you!

Detailed guidelines: https://gpac.io/bug-reporting/

Overview

Generating single channel files (e.g. palette or mono) results in corrupted results in gpac -gui for row and tile interleave mode.

Test cases:

gpac uncvg:sq=1:vsize=30x20:tiles=2x4:c=M:sampling=none:interleave=row:block_size=0:row_align=0:tile_align=0:fps=0 -o test1.heif
gpac uncvg:sq=1:vsize=30x20:tiles=2x4:c=M:sampling=none:interleave=tile:block_size=0:row_align=0:tile_align=0:fps=0 -o test2.heif
gpac uncvg:sq=1:vsize=30x20:tiles=2x4:c=p:sampling=none:interleave=row:block_size=0:row_align=0:tile_align=0:fps=0 -o test3.heif
gpac uncvg:sq=1:vsize=30x20:tiles=2x4:c=p:sampling=none:interleave=tile:block_size=0:row_align=0:tile_align=0:fps=0 -o test4.heif
gpac uncvg:sq=1:vsize=30x20:c=M:sampling=none:interleave=row:block_size=0:row_align=0:tile_align=0:fps=0 -o test5.heif
gpac uncvg:sq=1:vsize=30x20:c=p:sampling=none:interleave=row:block_size=0:row_align=0:tile_align=0:fps=0 -o test6.heif
gpac uncvg:sq=1:vsize=30x20:c=x,M:sampling=none:interleave=row:block_size=0:row_align=0:tile_align=0:fps=0 -o test7.heif

Results

Test 1
image

Test 2
image

Test 3
image

Test 4
image

Test 5
image

Test 6
image

Test 7
image

(note: this is the expected result, but differs from Test 5 example only in that there is a pad channel.)

@bradh
Copy link
Contributor Author

bradh commented Dec 16, 2023

I have since implemented decode for the mono images, and they appear fine to me. So its likely on the display side rather than the uncvg side.

@jeanlf jeanlf closed this as completed in 613c833 Dec 20, 2023
@jeanlf
Copy link
Member

jeanlf commented Dec 20, 2023

indeed , should now be fixed. Thanks for the report

rbouqueau pushed a commit that referenced this issue Feb 1, 2024
gorinje pushed a commit to Bevara/Access-open that referenced this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants