Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Small chunk size will not fire "onSamples" #205

Closed
motoyasu-yamada opened this issue Aug 9, 2020 · 5 comments
Closed

Bug: Small chunk size will not fire "onSamples" #205

motoyasu-yamada opened this issue Aug 9, 2020 · 5 comments

Comments

@motoyasu-yamada
Copy link

motoyasu-yamada commented Aug 9, 2020

When "the sample does not end in this buffer" in function "ISOFile.getSample", subsequent partials will not be loaded. Then "getSmaple" return null.

processSamples function in isofile.js receive null and so will not fire "onSamples".

ISOFile.prototype.processSamples = function(last) {
:
				var sample = this.getSample(trak, trak.nextSample);
				if (sample) {
					trak.nextSample++;
					extractTrak.samples.push(sample);
				} else {
					break;
				}
motoyasu-yamada added a commit to motoyasu-yamada/mp4box.js that referenced this issue Aug 9, 2020
@dalecurtis
Copy link

Awesome, thanks for the fix!

@dalecurtis
Copy link

Bump @cconcolato since a lot of folks hit this issue when trying to use the streaming API.

@cconcolato
Copy link
Member

The issue should be fixed with 2bfb7a5. Please open a new issue if this is not the case.

@elhigu
Copy link

elhigu commented Dec 11, 2020

Is this already released in npm? I could try it out.

@cconcolato
Copy link
Member

Yes, should be in latest npm version (0.4.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants