Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing ']' in substitution- ln122 #3

Closed
wants to merge 1 commit into from

Conversation

aenichols
Copy link

image

image

image

Issue with path separators on windows. I suggest converting the filepath to '/' if you are on windows.

@gpanders
Copy link
Owner

gpanders commented Oct 7, 2021

Thanks! I do not use Windows and so none of this plugin has been tested on Windows. If you're willing to help me do that we can work out these bugs.

Nvim converts / to \ internally on Windows automatically, so the only place we need to use \ is when we're actually matching against a file path (I think). That is what the convert-pathseps function is meant to do.

@gpanders
Copy link
Owner

gpanders commented Oct 7, 2021

Can you try the windows branch for me?

@aenichols
Copy link
Author

I will give this a try tomorrow morning, thanks for the help.

@gpanders
Copy link
Owner

Did you ever get a chance to try that branch? If it resolves your issue, I’ll merge it.

@aenichols
Copy link
Author

Did you ever get a chance to try that branch? If it resolves your issue, I’ll merge it.

Sorry, it took me so long. I did just pull it down and everything seems to be working as expected. =]

@gpanders gpanders closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants