Rietveld patches

[jrioux]

Include binary data in the patch upload to Rietveld. This works with both "git cl patch X" and "test-patches" aka Patchy. Tested this myself with https://codereview.appspot.com/13054043/

Also update to use https.

[jrioux]

So this has been tested "in the wild" and it looks like it is doing the right thing (https://codereview.appspot.com/12980044/ patch set 2 now includes the images) but it doesn't help Patchy much because Rietveld won't let you download patches that are too large. Obviously, including the binary data is bound to producing large patches. So this pull request, although still an improvement, isn't helping to the extend that I was hoping for.

[PhilHolmes]

I think it's still an improvement and should be used - I assume it would work with a patch with fewer image changes.

Phil Holmes

----- Original Message -----
From: Julien Rioux
To: gperciva/git-cl
Sent: Sunday, August 18, 2013 8:08 AM
Subject: Re: [git-cl] Rietveld patches (#2)

So this has been tested "in the wild" and it looks like it is doing the right thing (https://codereview.appspot.com/12980044/ patch set 2 now includes the images) but it doesn't help Patchy much because Rietveld won't let you download patches that are too large. Obviously, including the binary data is bound to producing large patches. So this pull request, although still an improvement, isn't helping to the extend that I was hoping for.

—
Reply to this email directly or view it on GitHub.

[gperciva]

LGTM, please push

[jrioux]

Thanks, merging...