Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rietveld's "too large to download" patches. #3

Merged
merged 1 commit into from
Aug 30, 2013

Conversation

jrioux
Copy link
Collaborator

@jrioux jrioux commented Aug 20, 2013

Allow to download "too large to download" patchsets.

Avoid the 404 error on patchsets that are "too large". Since patch download links are available for individual files, we donwload them and concatenate them to obtain the complete patch. curl allows us to do this in one go.

Workaround for Rietveld issue 196:
http://code.google.com/p/rietveld/issues/detail?id=196

Test bed: Rietveld issue 12980044
https://codereview.appspot.com/12980044/

Avoid the 404 error on patchsets that are "too large".
Since patch download links are available for individual
files, we donwload them and concatenate them to obtain
the complete patch. curl allows us to do this in one go.

Workaround for Rietveld issue 196:
http://code.google.com/p/rietveld/issues/detail?id=196
jrioux added a commit that referenced this pull request Aug 30, 2013
Rietveld's "too large to download" patches.
@jrioux jrioux merged commit 3f85724 into gperciva:master Aug 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant