New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported to .NET Standard / .NET Core #5

Closed
Daniel15 opened this Issue Jan 31, 2019 · 8 comments

Comments

Projects
None yet
2 participants
@Daniel15
Copy link
Member

Daniel15 commented Jan 31, 2019

Hi! Thanks to you and @danm-de for the nice library.

I was wondering whether you're still maintaining it? I wanted to use it in a .NET Core 2.0 app, so I've ported it to .NET Standard (you can see my changes here: Daniel15#1) and published it to NuGet: https://www.nuget.org/packages/gpgme-sharp. I'm also planning on adding some basic unit/integration tests.

Let me know if you'd like me to submit a pull request with my changes, or add you as an admin to the NuGet package.

Thanks!

@wget

This comment has been minimized.

Copy link
Collaborator

wget commented Feb 1, 2019

@Daniel15 Sure you can provide send me a pull request. I would also be happy to have the admin rights on the nuget package. My nickname on nuget is wget as well.

@Daniel15

This comment has been minimized.

Copy link
Member Author

Daniel15 commented Feb 1, 2019

Thanks, submitted as #6

@Daniel15 Daniel15 closed this Feb 1, 2019

@Daniel15

This comment has been minimized.

Copy link
Member Author

Daniel15 commented Feb 1, 2019

@wget Actually, what do you think of moving the repo to a GitHub org rather than keeping it as just a personal repo? I just created a gpgme-sharp org and added you as an owner: https://github.com/gpgme-sharp. For example I'd like to configure Azure DevOps to build the code, but enabling it requires admin access to the repo.

@Daniel15 Daniel15 reopened this Feb 1, 2019

@wget

This comment has been minimized.

Copy link
Collaborator

wget commented Feb 4, 2019

@Daniel15 Yes, I know the issue of not being an admin :) Indeed having an organization is better in this regard when doing CI stuff. I'll move the repo to the organization today. :)
If you can give me access to the CI build system, this would be nice of you.

@Daniel15

This comment has been minimized.

Copy link
Member Author

Daniel15 commented Feb 4, 2019

@Daniel15

This comment has been minimized.

Copy link
Member Author

Daniel15 commented Feb 11, 2019

@wget Do you think you'll move this repo to the org soon, if you're okay with that? I can set up the CI stuff once it's there. Otherwise, I could move my fork. I've got a few other PRs I'd like to submit too... Will get to those soon.

@wget

This comment has been minimized.

Copy link
Collaborator

wget commented Feb 11, 2019

@Daniel15 moved to the org :) You're doing a great work! :)

@Daniel15

This comment has been minimized.

Copy link
Member Author

Daniel15 commented Feb 11, 2019

Nice, thanks!

@Daniel15 Daniel15 closed this Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment