This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Basic support for undef values #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing due to inaction. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm trying out Chart::Clicker as a replacement for the ancient Chart module, and so far it looks great, except that it doesn't handle series with missing values. This might be needed, for example, if you have two share prices to plot but there is no price for one of them on a given day because of a holiday. This patch adds the minimal support for series with undef values to be handed; when drawing a line chart the line will go unbroken from the previous to the next observation, which is good enough. I may add more sophisticated support for series with missing values later.
Let me know what you think and whether you're willing to apply the patch and add this functionality.