Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default number of workers to 1 #273

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Reduce default number of workers to 1 #273

merged 3 commits into from
Jan 6, 2021

Conversation

pacoorozco
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #271

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Change the default number of workers to 1. So it will not use concurrency by default.

Signed-off-by: pacoorozco <paco@pacoorozco.info>
Signed-off-by: pacoorozco <paco@pacoorozco.info>
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #273 (9b45c19) into master (4702c0e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   63.87%   63.87%           
=======================================
  Files          21       21           
  Lines         609      609           
=======================================
  Hits          389      389           
  Misses        195      195           
  Partials       25       25           
Impacted Files Coverage Δ
internal/cmd/push.go 13.33% <100.00%> (ø)
internal/config/config.go 84.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4702c0e...941095d. Read the comment docs.

Signed-off-by: pacoorozco <paco@pacoorozco.info>
@pacoorozco pacoorozco merged commit 761cdb9 into master Jan 6, 2021
@pacoorozco pacoorozco deleted the issue-271 branch January 6, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default parameters to safer one.
1 participant