Skip to content

Commit

Permalink
Clean up various FIXMEs by code updates
Browse files Browse the repository at this point in the history
  • Loading branch information
thp committed Oct 31, 2011
1 parent 7eca6b5 commit a72bf2b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions src/gpodder/opml.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,12 @@ def write( self, channels):
# don't end up with a clobbed, empty opml file.
FREE_DISK_SPACE_AFTER = 1024*512
available = util.get_free_disk_space(os.path.dirname(self.filename))
if available < 2*len(data)+FREE_DISK_SPACE_AFTER and not gpodder.win32:
# FIXME: get_free_disk_space still unimplemented for win32
logger.error('Not enough free disk space to save channel list to %s', self.filename)
return False
if available < 2*len(data)+FREE_DISK_SPACE_AFTER:
# On Windows, if we have zero bytes available, assume that we have
# not had the win32file module available + assume enough free space
if not gpodder.win32 or available > 0:
logger.error('Not enough free disk space to save channel list to %s', self.filename)
return False
fp = open(self.filename+'.tmp', 'w')
fp.write(data)
fp.close()
Expand Down
2 changes: 1 addition & 1 deletion src/gpodder/qmlui/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def _sourceurl(self):
qsourceurl = Property(unicode, _sourceurl, notify=source_url_changed)

def _filetype(self):
return self._episode.file_type() or 'download' # FIXME
return self._episode.file_type() or 'download'

qfiletype = Property(unicode, _filetype, notify=never_changed)

Expand Down

0 comments on commit a72bf2b

Please sign in to comment.