Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current git does not work with yt-dlp 2022.04.08 #1439

Closed
auouymous opened this issue Nov 21, 2022 · 2 comments · Fixed by #1440
Closed

Current git does not work with yt-dlp 2022.04.08 #1439

auouymous opened this issue Nov 21, 2022 · 2 comments · Fixed by #1440

Comments

@auouymous
Copy link
Member

642bf7e in #1382 causes the following error when downloading episodes with yt-dlp 2022.04.08:

Traceback (most recent call last):
  File "/home/test/git-gpodder-tmp/src/gpodder/download.py", line 900, in run
    headers, real_url = downloader.retrieve_resume(self.tempname, self.status_updated)
  File "/home/test/git-gpodder-tmp/share/gpodder/extensions/youtube-dl.py", line 109, in retrieve_resume
    opts['paths']['home'], opts['outtmpl']['default']) % info
TypeError: string indices must be integers

I haven't yet determined which version of yt-dlp is required to make #1382 work. This issue either needs to be fixed for older versions of yt-dlp, or gpodder needs to split want_ytdl_version to support separate versions for youtube-dl and yt-dlp, which I already had plans to do. @tpikonen Do you know an easy fix for this or should we require a newer yt-dlp?

@auouymous
Copy link
Member Author

It is now possible for yt-dlp to require a different version than youtube-dl. However, yt-dlp 2022.04.08 is currently the latest available for Mint and Ubuntu.

auouymous added a commit to auouymous/gpodder that referenced this issue Nov 22, 2022
auouymous added a commit to auouymous/gpodder that referenced this issue Nov 22, 2022
PR gpodder#1382 broke support for yt-dlp versions prior to 2022.6.22.1.

Fixes gpodder#1439.
@auouymous
Copy link
Member Author

2022.5.18 also fails, and 2022.06.22.1 is the first version that works. #1440 should make gpodder work on both versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant