Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for old versions of yt-dlp. #1440

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix support for old versions of yt-dlp. #1440

merged 1 commit into from
Nov 22, 2022

Conversation

auouymous
Copy link
Member

PR #1382 broke support for yt-dlp versions prior to 2022.6.22.1.

Fixes #1439.

@auouymous
Fix support for old versions of yt-dlp.
87421c8 
PR gpodder#1382 broke support for yt-dlp versions prior to 2022.6.22.1.

Fixes gpodder#1439.
@auouymous auouymous mentioned this pull request Nov 22, 2022
Closed
tpikonen
tpikonen approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@tpikonen tpikonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine and works ok on post 2022.06.22.1 yt-dlp.

@tpikonen
Copy link
Contributor

Thanks for fixing this. Unfortunately it seems that yt-dlp does not provide a stable Python API.

@auouymous auouymous merged commit d842a78 into gpodder:master Nov 22, 2022
@auouymous auouymous deleted the fix-old-versions-of-ytdlp branch November 22, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpikonen tpikonen tpikonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current git does not work with yt-dlp 2022.04.08
2 participants
@auouymous @tpikonen