Improvements to the extension system #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,9 @@ def main(): | |||
| gpodder.ui.qml = True | |||
| else: | |||
| gpodder.ui.gtk = True | |||
|
|
|||
| gpodder.ui.unity = (os.environ.get('DESKTOP_SESSION').lower() in | |||
There was a problem hiding this comment.
You need to add a string as a default value or it will crash here when DESKTOP_SESSION does not exist.
|
Can you once again stash these two commits together into a single one? :) Also, is it ready to go in or do you want me to have a deeper look over it? |
- Add category metadata in every extension - Show this category in the extension list gui - Add "mandatory_in" and "disable-in" configuration for an extension - Add Ubuntu unity check to enable/disable unity specific extensions - Move "gpodder.win32" and "gpodder.osx" setting to the "gpodder.ui" namespace to be able to use it in the extensions category settings - Only show metadata information in the right-click dialog of an extension
|
Ok, now it's again only one commit. |
thp
added a commit
that referenced
this pull request
Dec 17, 2012
Improvements to the extension system
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone should test the changes on Windows and MacOSX. I don't have Windows or Mac at home to test this changes!