Removed insertid calls from installer adapters to avoid pitfalls rela…

…ted to JTable::store
gpongelli · Apr 4, 2012 · a97e2ff · a97e2ff
1 parent bd747b5
commit a97e2ff
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/libraries/joomla/installer/adapters/component.php b/libraries/joomla/installer/adapters/component.php
@@ -541,7 +541,7 @@ public function install()
 			return false;
 		}
 
-		$eid = $db->insertid();
+		$eid = $row->extension_id;
 
 		// Clobber any possible pending updates
 		$update = JTable::getInstance('update');

diff --git a/libraries/joomla/installer/adapters/file.php b/libraries/joomla/installer/adapters/file.php
@@ -254,9 +254,6 @@ public function install()
 				return false;
 			}
 
-			// Set the insert id
-			$row->set('extension_id', $db->insertid());
-
 			// Since we have created a module item, we add it to the installation step stack
 			// so that if we have to rollback the changes we can undo it.
 			$this->parent->pushStep(array('type' => 'extension', 'extension_id' => $row->extension_id));

diff --git a/libraries/joomla/installer/adapters/module.php b/libraries/joomla/installer/adapters/module.php
@@ -427,9 +427,6 @@ public function install()
 				return false;
 			}
 
-			// Set the insert id
-			$row->extension_id = $db->insertid();
-
 			// Since we have created a module item, we add it to the installation step stack
 			// so that if we have to rollback the changes we can undo it.
 			$this->parent->pushStep(array('type' => 'extension', 'extension_id' => $row->extension_id));