Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Symfony 4 bin/composer directory structure #9

Merged
merged 5 commits into from
Jul 30, 2019
Merged

New Symfony 4 bin/composer directory structure #9

merged 5 commits into from
Jul 30, 2019

Commits on Jul 26, 2019

  1. New Symfony 4 bin/composer directory structure

    Hi thanks for this helpful bundle. The update script anticipates the need to use 'bin' rather than 'app' but the method useNewDirectoryStructure is looking for symfony-var-dir option.  I added the symfony-bin-dir directory as an explicit option and the useNewDirectoryStructure method to look for that.  I think this will help keep the script working with projects independent of 'symfony-var-dir' .  Thanks!
    ChrisKinnan committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    ff1834c View commit details
    Browse the repository at this point in the history
  2. Update ScriptHandler.php

    ChrisKinnan committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    8e8f675 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Update ScriptHandler.php

    ChrisKinnan committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    bd5d6ed View commit details
    Browse the repository at this point in the history
  2. Update README.md

    Took a deeper dive on this and it turns out we can just call the Command directly.  Updated the docs, thank you.
    ChrisKinnan committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    b7ac6c1 View commit details
    Browse the repository at this point in the history
  3. Update README.md

    ChrisKinnan committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    5dc008b View commit details
    Browse the repository at this point in the history