New Symfony 4 bin/composer directory structure #9
Conversation
Hi thanks for this helpful bundle. The update script anticipates the need to use 'bin' rather than 'app' but the method useNewDirectoryStructure is looking for symfony-var-dir option. I added the symfony-bin-dir directory as an explicit option and the useNewDirectoryStructure method to look for that. I think this will help keep the script working with projects independent of 'symfony-var-dir' . Thanks!
|
Thanks for report |
| @@ -151,7 +152,7 @@ private static function hasDirectory(Event $event, $config_name, $path, $action_ | |||
| */ | |||
| private static function useNewDirectoryStructure(array $options) | |||
| { | |||
| return isset($options['symfony-var-dir']) && is_dir($options['symfony-var-dir']); | |||
| return isset($options['symfony-bin-dir']) && is_dir($options['symfony-bin-dir']); | |||
There was a problem hiding this comment.
This change may break BC. Need check symfony-var-dir and symfony-bin-dir options.
There was a problem hiding this comment.
I wasn't sure what symfony-var-dir is doing...it looks like it is just acting as a signal for a certain version of Symfony? Are users setting that value outside of the script? Thanks.
There was a problem hiding this comment.
Sorry. I hurried. This method is needed to identify the new folder structure in Symfony.
This code is a copy/paste of the SensioDistributionBundle.
https://github.com/sensiolabs/SensioDistributionBundle/blob/master/Composer/ScriptHandler.php
Are you sure that this code does not work in Symfony 4 as it is?
There was a problem hiding this comment.
Yeah it breaks-- Symfony put console into the bin/console directory
There was a problem hiding this comment.
You can solve the problem by setting up composer.json:
{
# ...
"extra": {
"symfony-var-dir": "var",
"symfony-bin-dir": "bin"
}
}There was a problem hiding this comment.
I approve replacement option symfony-var-dir to symfony-bin-dir 👍
There was a problem hiding this comment.
You may not want to make any change to useNewDirectoryStructure method, this code isn't needed for SF 4 and might break someone's older implementation.
There was a problem hiding this comment.
I can offer this option which, in theory, should work the same in Symfony 4 and older versions.
if (isset($options['symfony-bin-dir'])) {
return is_dir($options['symfony-bin-dir']);
} else {
return is_dir('bin');
}Although it can also break BC.
Took a deeper dive on this and it turns out we can just call the Command directly. Updated the docs, thank you.
|
Thanks for the work you've done. |
Hi thanks for this helpful bundle. The update script anticipates the need to use 'bin' rather than 'app' but the method useNewDirectoryStructure is looking for symfony-var-dir option. I added the symfony-bin-dir directory as an explicit option and the useNewDirectoryStructure method to look for that. I think this will help keep the script working with projects independent of 'symfony-var-dir' . Thanks!