fix: windows absolute path logic #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpebcak
requested review from
ibuildthecloud,
thedadams,
cjellick,
njhale,
StrongMonkey,
g-linville and
tylerslaton
|
This change was originally suggested by Darren, but I'm not sure he intended it to be the actual fix since it changes the behavior mentioned in the comment. Does anyone have an alternate suggestion? |
|
The comment is correct, but in the wrong place. We want to use path.Join and not filepath.Join. As some point the IsAbs check was added and the comment should have gone inside the if. We want the comment because it still holds true. IsAbs does not mutate the path but just checks for both cases. |
ibuildthecloud
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue seen at least in clio, with the ability to load external agents.