Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presubmit check for long test names #1165

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

austinEng
Copy link
Collaborator

Very long test names cause problems on Chrome's infrastructure.
And, long test names probbably imply that the test has been
overparamterized and should be split.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Very long test names cause problems on Chrome's infrastructure.
And, long test names probbably imply that the test has been
overparamterized and should be split.
@austinEng austinEng requested a review from Kangz April 13, 2022 23:18
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@austinEng austinEng enabled auto-merge (squash) April 13, 2022 23:21
@austinEng austinEng merged commit cd7e9e9 into gpuweb:main Apr 13, 2022
@austinEng austinEng deleted the name-limit branch April 13, 2022 23:22
@github-actions
Copy link

Previews, as seen when this build job started (fb5b34f):
Run tests | View tsdoc

@Kangz
Copy link
Collaborator

Kangz commented Apr 14, 2022

Does this presubmit run automatically in Github actions?

@austinEng
Copy link
Collaborator Author

Yes, the actions run grunt pre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants