Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise maxComputeWorkgroupStorageSize from 16352 to 16384 #1390

Merged
merged 1 commit into from
May 18, 2022

Conversation

austinEng
Copy link
Collaborator

Issue: gpuweb/gpuweb#2834


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@austinEng austinEng requested a review from kainino0x May 11, 2022 16:49
@github-actions
Copy link

Previews, as seen when this build job started (dd7e33a):
Run tests | View tsdoc

@Kangz
Copy link
Collaborator

Kangz commented May 18, 2022

Merging now as it will help with rolling the CTS in Dawn.

@Kangz Kangz merged commit 8f2742e into gpuweb:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants