Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise maxComputeWorkgroupStorageSize from 16352 to 16384 #2834

Merged
merged 1 commit into from May 16, 2022

Conversation

kainino0x
Copy link
Contributor

@kainino0x kainino0x commented May 6, 2022

16352 was only required for Metal families Apple1/Apple2 which we don't support anymore anyway.

Issue: #2832


Preview | Diff

16352 was only required for Metal families Apple1/Apple2 which we don't
support anymore anyway.
@kainino0x kainino0x added for webgpu editors meeting tacit resolution queue Editors have agreed and intend to land if no feedback is given labels May 6, 2022
@kainino0x kainino0x added this to the V1.0 milestone May 6, 2022
@kainino0x kainino0x requested a review from toji May 6, 2022 20:55
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

Previews, as seen when this build job started (738acce):
WebGPU | IDL
WGSL
Explainer

Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaass! Get those extra 32 bytes!

@kainino0x kainino0x merged commit 16c7f3b into gpuweb:main May 16, 2022
@kainino0x kainino0x added this to Needs CTS Issue in Main May 16, 2022
github-actions bot added a commit that referenced this pull request May 16, 2022
SHA: 16c7f3b
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 16, 2022
SHA: 16c7f3b
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 16, 2022
SHA: 16c7f3b
Reason: push, by @kainino0x

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kainino0x kainino0x deleted the shared-16k branch May 16, 2022 23:08
@kainino0x kainino0x removed the tacit resolution queue Editors have agreed and intend to land if no feedback is given label May 16, 2022
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jun 29, 2022
@kainino0x kainino0x removed this from Needs CTS Issue in Main Jun 29, 2022
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
16352 was only required for Metal families Apple1/Apple2 which we don't
support anymore anyway.
@lokokung lokokung removed the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants