New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise maxComputeWorkgroupStorageSize from 16352 to 16384 #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16352 was only required for Metal families Apple1/Apple2 which we don't support anymore anyway.
kainino0x
added
for webgpu editors meeting
tacit resolution queue
Editors have agreed and intend to land if no feedback is given
labels
May 6, 2022
toji
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yaass! Get those extra 32 bytes!
7 tasks
github-actions bot
added a commit
that referenced
this pull request
May 16, 2022
SHA: 16c7f3b Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 16, 2022
SHA: 16c7f3b Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
May 16, 2022
SHA: 16c7f3b Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kainino0x
removed
the
tacit resolution queue
Editors have agreed and intend to land if no feedback is given
label
May 16, 2022
kainino0x
added
the
needs-cts-issue
This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet
label
Jun 29, 2022
jdarpinian
pushed a commit
to jdarpinian/gpuweb
that referenced
this pull request
Aug 12, 2022
16352 was only required for Metal families Apple1/Apple2 which we don't support anymore anyway.
lokokung
removed
the
needs-cts-issue
This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet
label
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16352 was only required for Metal families Apple1/Apple2 which we don't support anymore anyway.
Issue: #2832
Preview | Diff