Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade typescript to 4.7.4 #1713

Merged
merged 3 commits into from
Aug 9, 2022
Merged

upgrade typescript to 4.7.4 #1713

merged 3 commits into from
Aug 9, 2022

Conversation

kainino0x
Copy link
Collaborator

Not entirely clear why upgrading caused type narrowing to fail in these
cases, but it's easy to fix.

Issue: none


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Not entirely clear why upgrading caused type narrowing to fail in these
cases, but it's easy to fix.
@kainino0x kainino0x requested a review from shaoboyan July 26, 2022 17:02
@kainino0x kainino0x enabled auto-merge (squash) July 26, 2022 17:03
@kainino0x
Copy link
Collaborator Author

@shaoboyan PTAL

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Previews, as seen when this build job started (9dc8a48):
Run tests | View tsdoc

Copy link
Contributor

@shaoboyan shaoboyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading and happy to remove requestVideoFrameCallback declare

@kainino0x kainino0x merged commit 40e52d1 into gpuweb:main Aug 9, 2022
@kainino0x kainino0x deleted the ts-upgrade branch August 10, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants