Do not require rasterizationState in GPURenderPipelineDescriptor #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaufortfrancois
changed the title
Kangz
approved these changes
Jun 26, 2019
RafaelCintron
approved these changes
Jun 28, 2019
Kangz
pushed a commit
to Kangz/gpuweb
that referenced
this pull request
Jul 9, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 17, 2019
…ptor Following WebGPU spec change at gpuweb/gpuweb#347, the rasterizationState from GPURenderPipelineDescriptor should not be required anymore as the default frontFace value is now set to "ccw". Bug: 877147 Change-Id: I5505681261ccedc131b3b5141c5a7ef4e3d15053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700079 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#678175}
13 tasks
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the default
frontFacevalue now set to "ccw" in #313, therasterizationStatefrom GPURenderPipelineDescriptor should not be required anymore.Preview | Diff