New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp query resets #4069
Comments
@haoxli do you know what needs to be added here? |
Thread where I requested this inline issue be added: #771 (comment) |
Sorry for my late reply, I missed this notification. On Nivdia/AMD GPUs, their GPU timestamps from query API are nanoseconds since POSIX time (also known as Epoch time, Unix time), timestamps have always been positive growth. To my knowledge, timestamp query resets will happen on Intel GPUs, its GPU counter restart from a big number every few hours. So we have to make user aware that we should skip and do not compare the timestamp values if any timestamp is less than the previous one. On Apple GPUs, the GPU counter is similar to Intel GPUs, but its timestamps are much bigger than the values on Intel and Nividia GPUs. I'm not sure what will happen if the counter reaches the maximum limitation (may never reach if the counter is large enough).
This is out of date. We don't need to make the timestamps to be 0s when timestamp query resets, which will complicate the implementation of the compute shader for timestamp conversion. Talked with Corentin in sync meeting before, just notice users to take care of the timestamps which may be reset. |
Fixes #4069 Removes the reference to timestamps being zeroed out and instead encourages developers to be aware of occasional nonsensical values.
Resolved in 2023-05-24 meeting: just describe in the spec when/how timestamp resets can occur, don't try to guarantee anything more |
I'm migrating this from an inline issue:
I do not know what needs to be written here. More detail from #614 which I assume is about the same thing:
Regardless since this is defined in the V1 spec (even though implementations may ship without it, as Chrome does), marking as V1.
The text was updated successfully, but these errors were encountered: