Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise maxVertexBuffers default to 16 #4284

Open
kainino0x opened this issue Sep 7, 2023 · 0 comments
Open

Raise maxVertexBuffers default to 16 #4284

kainino0x opened this issue Sep 7, 2023 · 0 comments
Labels
Milestone

Comments

@kainino0x
Copy link
Contributor

kainino0x commented Sep 7, 2023

Currently maxVertexBuffers defaults to 8, but this is a regression compared with WebGL 2.0. All of the backends support 16, except...

In WebGPU implementations on Metal which are not using Metal's Argument Buffers, maxVertexBuffers contends with maxStorageBuffersPerShaderStage and maxUniformBuffersPerShaderStage for the Metal limit Maximum number of entries in the buffer argument table, per graphics or kernel function (#693 (comment)).

With argument buffers, this is no longer a problem, because we added the combined limit maxBindGroupsPlusVertexBuffers to take care of this (#2749). We just didn't add a limit for non-argument-buffers cases because that's backward-looking.

Per #1069 (comment) we no longer officially support Metal versions without argument buffers. However we'll want to hold off on raising this base limit until implementations are actually migrated to using argument buffers, so IMO this is no earlier than Milestone 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant