Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webgpu): Request Device with max limits (30 vertex attributes) #1971

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Feb 26, 2024

For #

Background

The luma.gl v9 MDX docs query the environment dynamically using the luma.gl API:

image

Change List

  • Docs
  • WebGPU device initialization

@ibgreen ibgreen marked this pull request as ready for review February 26, 2024 20:47
@@ -5,7 +5,7 @@
import {WebGLDevice} from '@luma.gl/webgl';
import {WebGPUDevice} from '@luma.gl/webgpu';
import AnimationLoopTemplate from './app.ts';
luma.registerDevices([WebGLDevice]);
luma.registerDevices([WebGPUDevice]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this example take advantage of increased limits?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't have any example that need that many attributes. I believe that is your area of expertise :)

I just switched this example to WebGPU to test the code path and inspect the limits, haven't actually tested in

@ibgreen ibgreen changed the title Maximize limits webgpu Maximize limits webgpu (30 vertex attributes) Feb 26, 2024
@ibgreen ibgreen changed the title Maximize limits webgpu (30 vertex attributes) feat(webgpu): Request Device with max limits (30 vertex attributes) Feb 27, 2024
@ibgreen ibgreen merged commit 91605be into master Feb 27, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/maximize-limits-webgpu branch February 27, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants