Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anisotropic clamping for SamplerDescriptor #696

Closed
kvark opened this issue Apr 10, 2020 · 6 comments · Fixed by #864
Closed

Anisotropic clamping for SamplerDescriptor #696

kvark opened this issue Apr 10, 2020 · 6 comments · Fixed by #864
Assignees
@kvark
Labels
bug
Projects
Main

Comments

@kvark
Copy link
Contributor

kvark commented Apr 10, 2020 •
edited by kainino0x

We have the anisotropic extension string, but no associated API to set the clamp.
I wonder how this will be specified: just adding a member to SamplerDescriptor may look like this is a part of the core spec.

See: #202
@cwfitzgerald cwfitzgerald mentioned this issue Apr 10, 2020
Closed
@kainino0x
Copy link
Contributor

kainino0x commented Apr 10, 2020 •
edited

nit: The "anisotropic-filtering" extension string was a placeholder extension string; since then we added a real extension "texture-compression-bc" so removed the placeholder. Obviously we should add back the extension (with actual support) though.

[rest of message moved to #701]

@kainino0x kainino0x mentioned this issue Apr 14, 2020
Closed
@kainino0x
Copy link
Contributor

You added the "for meeting" label; what do you want to discuss?

@kainino0x kainino0x added this to Needs Discussion in Main Apr 14, 2020
@kvark
Copy link
Contributor Author

kvark commented Apr 14, 2020

Basically, get everyone's 👍 for adding it to the WebIDL.

@kainino0x
Copy link
Contributor

Resolution: move anisotropic filtering to core, but make it a hint. If the device doesn't support anisotropic filtering, then it just won't happen.

Consider adding a query (maybe later?) that reports either 1 or 16(+?) for the max anisotropy.

@kainino0x kainino0x moved this from Needs Discussion to Needs Specification in Main Jun 15, 2020
@kdashg
Copy link
Contributor

kdashg commented Jun 15, 2020

2020-06-15 Meeting: Let's add a maxAnisotropy value to samplers, and a maxAnisotropy limit(? query?) (likely only ever 16 or 1), but not to validate that the former is less than the latter.

@kvark kvark mentioned this issue Jun 15, 2020
Merged
@kvark
Copy link
Contributor Author

kvark commented Jun 15, 2020

I don't think there is a consensus on exposing the limit/query. Made a proposed API PR in #864 without them.

@cwfitzgerald cwfitzgerald mentioned this issue Jun 26, 2020
Merged
bors bot added a commit to gfx-rs/wgpu that referenced this issue Jun 26, 2020
@bors @cwfitzgerald
Merge #751
b23b9ee 
751: Convert Extensions + Capabilities into Features r=kvark a=cwfitzgerald

**Connections**

Based on upcoming webgpu changes.

**Description**

Does what it says on the tin. The only notable change was classifying the AnisotropicFiltering extension as a WebGPU extension (per gpuweb/gpuweb#696, but no idea if that's the correct interpretation)

**Testing**

Will be tested by upcoming wgpu-rs PR.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
@kvark kvark closed this as completed in #864 Jul 6, 2020
@kainino0x kainino0x mentioned this issue Dec 2, 2020
Closed
@kainino0x kainino0x moved this from Needs Specification to Specification Done in Main Jan 19, 2022
@kainino0x kainino0x mentioned this issue Mar 17, 2022
Merged
webkit-commit-queue pushed a commit to WebKit/WebKit that referenced this issue Mar 22, 2022
@litherum
[WebGPU] maxAnisotropy > 16 is clamped, rather than illegal
c8562df 
https://bugs.webkit.org/show_bug.cgi?id=238063

Reviewed by Kimmo Kinnunen.

See gpuweb/gpuweb#696 (comment)

> Let's add a maxAnisotropy value to samplers, and a maxAnisotropy limit(? query?) (likely only
> ever 16 or 1), but not to validate that the former is less than the latter.

Test: api/operation/sampling/anisotropy.spec.ts

* WebGPU/Sampler.mm:
(WebGPU::validateCreateSampler):
(WebGPU::Device::createSampler):


Canonical link: https://commits.webkit.org/248687@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this issue Sep 6, 2022
@shrekshao
Reftests expand with formats, write canvas methods, and compositingAl…
7fd57a4 
…phaMode (gpuweb#696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
bug
Projects
No open projects
Main
Specification Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add maxAnisotropy property kvark/gpuweb
3 participants
@kvark @kainino0x @kdashg