Tweak requiredBytesInCopy, make bytesPerRow/rowsPerImage optional #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytesPerRow and rowsPerImage are optional, but required if used. Both values always have to make sense if they're provided (regardless of whether they have an effect). This shuffles the contents of this algorithm around again, to: - Build requiredBytesInCopy incrementally. - Remove the special-case for `width==0 || height==0 || depth==0`. Notably this changes the validation so that, e.g., for a `0x2x0` copy, `bytesPerRow * (2 - 1)` bytes are still required. Fixes gpuweb#984
|
Let's air this one at the meeting. |
Kangz
approved these changes
Aug 20, 2020
|
Discussed at the 2020-08-24 meeting. |
kdashg
approved these changes
Aug 24, 2020
|
Resolution: merge |
kainino0x
added a commit
to kainino0x/gpuweb
that referenced
this pull request
Oct 3, 2020
I previously updated this in gpuweb#1014. This PR fixes some cases where requiredBytesInCopy was too large: - 2x0x0: previously 2 * block size, now 0. - 2x2x0: previously 4 * block size, now 0.
kvark
pushed a commit
that referenced
this pull request
Oct 5, 2020
I previously updated this in #1014. This PR fixes some cases where requiredBytesInCopy was too large: - 2x0x0: previously 2 * block size, now 0. - 2x2x0: previously 4 * block size, now 0.
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytesPerRow and rowsPerImage are optional, but required if used.
Both values always have to make sense if they're provided (regardless of
whether they have an effect).
This shuffles the contents of this algorithm around again, to:
width==0 || height==0 || depth==0.Notably this changes the validation so that, e.g., for a
0x2x0copy,bytesPerRow * (2 - 1)bytes are still required.First proposed here: #1006 (comment)
Fixes #984
Preview | Diff