Add filtered texture and sampler binding types #1076
Conversation
| : {{GPUBindingType/"comparison-sampler"}} | ||
| :: the |binding| is a comparison sampler | ||
| : {{GPUBindingType/"sampled-texture"}} | ||
| :: the |binding| is a sampled texture with the component type of |entry|.{{GPUBindGroupLayoutEntry/textureComponentType}} | ||
| :: The |binding| is a sampled texture with the component type of |entry|.{{GPUBindGroupLayoutEntry/textureComponentType}}, | ||
| and it has to have a sample count of 1. |
There was a problem hiding this comment.
hm, what sample count does this refer to? This is talking about the binding type inside the shader, right? So rather than sample count I think it should say it's non-multisampled (or more precisely refer to the actual type from WGSL).
There was a problem hiding this comment.
indeed! Not directly related to the PR though
|
Names are updated, the PR is rebased (and mostly reimplemented given the amount of conflicts...). Please take another look! |
| @@ -3381,12 +3410,20 @@ A {{GPUProgrammableStageDescriptor}} describes the entry point in the user-provi | |||
| 1. If |entry|.{{GPUBindGroupLayoutEntry/type}} is: | |||
| <dl class=switch> | |||
| : {{GPUBindingType/"sampler"}} | |||
| :: the |binding| is a non-comparison sampler | |||
| :: the |binding| is a non-comparison sampler, and all the textures it samples | |||
There was a problem hiding this comment.
nit: ideally things in this switch should be more specific, like compareEnable is false instead of "non-comparison", but probably not worth fixing this right now
There was a problem hiding this comment.
Hmm, upon further consideration, not sure if we'd be able to use that language here.
This spec text talks about the bindings reflected from the shader. So it's sort of an abstract thing, it generally has less information than the bindings on the API side. We could base this off the implicit bind group layout logic, but I think that would be a very wrong thing to do :)
There was a problem hiding this comment.
Oh, for some reason I thought the "is a non-comparison sampler" was talking about the sampler itself and not the type of the binding variable in the shader. If the latter, we should say "sampler (not sampler_comparison)" here and "sampler_comparison or sampler" there, or something.
|
Alright, thank you for the quick reviews! |
|
We only need to care if about filtering for float formats that don't support it since it's disallowed on D3D12 for all integer formats anyway. Maybe to reduce the members in |
|
This became a part of #1223 |
1047: Update bind group layout API to match upstream r=cwfitzgerald a=kvark **Connections** Follows gpuweb/gpuweb#1076, gpuweb/gpuweb#1223 (gpuweb/gpuweb#1164), gpuweb/gpuweb#1255, and gpuweb/gpuweb#1256 **Description** Aligns our API closer to the latest changes in WebGPU upstream. We technically don't have to do this, but I believe in the end it would be best if our API gets close to upstream. Note: this is a sensitive change for the users, everybody will get their code broken. So please take a look at the API and see if something is missing or needs improvement, so that we don't have to go through the changes again afterwards. **Testing** Doesn't really need testing. Partially covered by the existing playtest. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
* wgsl: Add validation tests for tokenization Covers the following cases: - Empty module - Null characters - Whitespace (delimiters) - Comments - Identifiers
Fixes #1034
Given the discussion on the issue, we can't have even the
Floatcomponent type linearly sampled if the format doesn't support this. The only way to catch that early is having these new binding types.Names are up to bikeshedding!
Preview | Diff