Use namespaces for flags instead of interfaces #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
force-pushed
the
flags-namespaces
branch
from
8041c4e
to
2492935
Compare
Kangz
approved these changes
May 4, 2021
kvark
approved these changes
May 4, 2021
|
Filed plinss/widlparser#66 on widlparser |
toji
approved these changes
May 4, 2021
|
Note that lines 1237 and 1238 can now be removed: Lines 1237 to 1238 in 2492935 |
|
@ExE-Boss sharp eye, thanks! |
|
This seems like it can be landed? |
kainino0x
force-pushed
the
flags-namespaces
branch
from
b207e78
to
b5aef17
Compare
|
Latest bikeshed should probably have the fix. Updated and attempting auto-merge |
|
jk, it already failed. |
github-actions bot
added a commit
that referenced
this pull request
Sep 10, 2021
…0.3 (#1709) SHA: db763f6 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Sep 10, 2021
…0.3 (#1709) SHA: db763f6 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Sep 10, 2021
…0.3 (#1709) SHA: db763f6 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304. Thanks @domenic!
Unfortunately for our CI, I think we have to wait for widlparser to be updated, and for that to be rolled into bikeshed.
💥 Error: 504 Gateway Time-out 💥
PR Preview failed to build. (Last tried on Sep 10, 2021, 7:45 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.